Skip to content

Fix github context echoing#97

Merged
ejfine merged 5 commits intomainfrom
fix-get-values
Oct 1, 2025
Merged

Fix github context echoing#97
ejfine merged 5 commits intomainfrom
fix-get-values

Conversation

@ejfine
Copy link
Contributor

@ejfine ejfine commented Oct 1, 2025

Why is this change necessary?

Depending on the content of the commit message, the previous attempt to display the github context would error

How does this change address the issue?

Changes to using jq instead

What side effects does this change have?

None

How is this change tested?

Downstream repos

Other

Bumped some versions

Changed ruff in tests to not auto-combine context managers

Summary by CodeRabbit

  • Chores
    • Bumped tooling and dependencies (uv, boto3, FastAPI, Uvicorn, Nuxt UI, vue-tsc, ESLint, types for Node) to newer versions.
    • Updated Dev Container metadata; no behavior changes.
    • Added lint rule to mark SIM117 as unfixable.
    • Improved GitHub Actions output to pretty‑print GitHub context JSON via jq for clearer logs.
    • Minor lint config formatting and comment wording tweaks (no behavioral changes).

@ejfine ejfine requested a review from Copilot October 1, 2025 10:51
@ejfine ejfine self-assigned this Oct 1, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 1, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Bumps several dependency and tooling version constants, updates a devcontainer comment hash, adds an unfixable Ruff rule, and changes a workflow template to pretty-print the GitHub context. No control-flow, API, or exported-entity changes.

Changes

Cohort / File(s) Summary
Devcontainer
/.devcontainer/devcontainer.json, /.devcontainer/install-ci-tooling.py
Updated the devcontainer comment hash and bumped UV_VERSION from 0.8.19 to 0.8.22 in the installer script.
Context version constants
/extensions/context.py
Updated context dictionary version values: uv_version 0.8.19→0.8.22, boto3_version 1.40.30→1.40.41, fastapi_version 0.117.1→0.118.0, uvicorn_version 0.36.0→0.37.0, nuxt_ui_version ^3.3.3→^4.0.0, vue_tsc_version ^3.0.6→^3.1.0, eslint_version ^9.35.0→^9.36.0, types_node_version ^24.5.1→^24.6.0.
Lint configuration
/ruff-test.toml
Added an unfixable entry for rule SIM117.
Workflow template
/template/.github/workflows/get-values.yaml.jinja-base
Replaced single-line echo of GitHub context with a multiline shell block piping the JSON through jq to pretty-print the context.
Ruff config formatting
/ruff.toml
Minor formatting/wording adjustments in comments and unfixable rule list; no behavior changes to rules.

Sequence Diagram(s)

(No sequence diagram provided — changes are version/config updates without control-flow or runtime feature changes.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I nibble lines and count each tag,
Bumped versions snug beneath my flag.
Ruff left one rule to stand and stare,
jq makes JSON pretty, clean, and fair.
A tiny hop — the repo blooms, hooray! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description follows the template for the core sections but is missing the required “Link to Issue or Message thread” section at the top, so it does not fully conform to the repository’s description requirements. Please add a “Link to Issue or Message thread” section at the beginning of the pull request description with a reference to the relevant issue or discussion thread to meet the template requirements.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title succinctly identifies the main change of fixing how the GitHub context is echoed and clearly reflects the primary functional update described in the changeset without extraneous details.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-get-values

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b41bf5e and 113ec0e.

📒 Files selected for processing (2)
  • ruff-test.toml (1 hunks)
  • ruff.toml (2 hunks)
🔇 Additional comments (2)
ruff-test.toml (1)

18-20: Addition of SIM117 unfixable looks good

Marking SIM117 as unfixable matches the intent behind the comment and keeps Ruff from auto-merging pytest context managers. Thanks for capturing this nuance.

ruff.toml (1)

72-75: Unfixable list restructuring improves readability

Keeping the same rule set while tidying the formatting and comments reads cleaner without changing behavior.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with GitHub context echoing in CI workflows by replacing problematic echo commands with a more robust jq-based approach, and updates various dependency versions.

  • Replaced echo-based GitHub context display with jq to handle special characters in commit messages
  • Updated multiple dependency versions across Python and Node.js packages
  • Modified ruff configuration to prevent auto-combining of pytest context managers

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
template/.github/workflows/get-values.yaml.jinja-base Fixed GitHub context echoing using jq instead of echo
ruff-test.toml Added unfixable rule to prevent auto-combining pytest.raises context managers
extensions/context.py Updated multiple dependency versions for Python and Node.js packages
.devcontainer/install-ci-tooling.py Updated UV version to match context.py
.devcontainer/devcontainer.json Updated devcontainer context hash

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- name: Display full GitHub context
run: echo '${{ toJSON(github) }}'
run: |
jq . <<'JSON'
Copy link

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding error handling for the jq command. If the JSON is malformed, jq will exit with a non-zero status and fail the workflow step. Add || echo 'Failed to parse GitHub context JSON' to provide a fallback.

Suggested change
jq . <<'JSON'
jq . <<'JSON' || echo 'Failed to parse GitHub context JSON'

Copilot uses AI. Check for mistakes.
ruff-test.toml Outdated
Comment on lines +19 to +20
"SIM117", # pytest.raises context managers should generally be separate from others so they can be very specific about where the error is being raised from, so don't autofix this
]
Copy link

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is inconsistent with the rest of the file. The array items should be aligned with the opening bracket or use consistent 4-space indentation like other sections in this file.

Suggested change
"SIM117", # pytest.raises context managers should generally be separate from others so they can be very specific about where the error is being raised from, so don't autofix this
]
"SIM117", # pytest.raises context managers should generally be separate from others so they can be very specific about where the error is being raised from, so don't autofix this
]

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejfine ejfine merged commit 27a524d into main Oct 1, 2025
7 checks passed
@ejfine ejfine deleted the fix-get-values branch October 1, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants