Conversation
|
Caution Review failedThe pull request is closed. Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughProject updates include version bumps for tooling and extensions, a new install_claude_cli option across copier templates and tests, conditional Anthropic env wiring in devcontainer, an added --allow-uv-to-install-python flag in the installer, README/CONTRIBUTING text tweaks, pre-commit exclusions for SVGs, and .gitignore cache entries removal. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant Inst as install-ci-tooling.py
participant UV as uv
Note over Dev,Inst: Installer invocation with optional flag
Dev->>Inst: python install-ci-tooling.py [--allow-uv-to-install-python]
Inst->>Inst: Set UV_PYTHON = requested version
alt Flag not provided
Inst->>Inst: Set UV_PYTHON_PREFERENCE = "only-system"
else Flag provided
Inst->>Inst: Do not set UV_PYTHON_PREFERENCE
end
Inst->>UV: Install tools using configured env
UV-->>Inst: Exit status
Inst-->>Dev: Completion
sequenceDiagram
autonumber
actor User as Template user
participant Copier as Copier
participant Devc as Devcontainer
participant Compose as docker-compose.yml
Note over User,Copier: Project generation with new option
User->>Copier: Answer install_claude_cli = true/false
Copier-->>Devc: Render devcontainer.json and extensions
alt install_claude_cli = true
Devc->>Devc: Include Claude CLI feature and extension
Devc->>Compose: Render ANTHROPIC_API_KEY passthrough
else install_claude_cli = false
Devc->>Devc: Exclude Claude CLI feature/extension
Devc->>Compose: No Anthropic env
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Claude CLI integration to the copier template, allowing users to optionally install the Claude Code extension in their devcontainer environment. It also includes several dependency version bumps and minor improvements.
- Adds a new
install_claude_cliconfiguration option to enable Claude CLI installation - Updates multiple dependency versions including UV, Node.js features, VS Code extensions, and Python packages
- Includes minor documentation improvements and spelling corrections
Reviewed Changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| copier.yaml | Adds install_claude_cli configuration option |
| template/copier.yml.jinja-base | Adds install_claude_cli question to template |
| template/.devcontainer/devcontainer.json.jinja-base | Conditionally installs Claude Code feature and extension |
| template/.devcontainer/docker-compose.yml.jinja-base | Adds ANTHROPIC_API_KEY environment variable when Claude CLI enabled |
| extensions/context.py | Updates multiple dependency versions |
| template/.devcontainer/install-ci-tooling.py.jinja-base | Adds --allow-uv-to-install-python flag support |
| tests/copier_data/data*.yaml | Updates test data with Claude CLI configuration |
| template/tests/copier_data/data*.yaml.jinja-base | Updates template test data |
| pyproject.toml | Updates pyright version |
| .devcontainer/install-ci-tooling.py | Updates UV version |
| README.md | Updates installation instructions |
| CONTRIBUTING.md | Fixes GitHub spelling |
| _typos.toml | Fixes "misspell" spelling |
| ruff-test.toml | Fixes "don't" contraction |
| .pre-commit-config.yaml | Adds SVG file exclusions |
| .devcontainer/devcontainer.json | Updates devcontainer hash |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+19
to
+20
| - AWS_DEFAULT_REGION={% endraw %}{{ aws_region_for_stack if (aws_region_for_stack is defined and aws_region_for_stack != "") else "us-east-1" }}{% raw %}{% endraw %}{% if install_claude_cli %}{% raw %}, | ||
| - ANTHROPIC_API_KEY: ${ANTHROPIC_API_KEY}{% endraw %}{% endif %}{% raw %} |
There was a problem hiding this comment.
The YAML syntax is incorrect. The comma should not be on the same line as the AWS_DEFAULT_REGION value, and the ANTHROPIC_API_KEY entry should not have a colon after the key name in the environment list.
Suggested change
| - AWS_DEFAULT_REGION={% endraw %}{{ aws_region_for_stack if (aws_region_for_stack is defined and aws_region_for_stack != "") else "us-east-1" }}{% raw %}{% endraw %}{% if install_claude_cli %}{% raw %}, | |
| - ANTHROPIC_API_KEY: ${ANTHROPIC_API_KEY}{% endraw %}{% endif %}{% raw %} | |
| - AWS_DEFAULT_REGION={% endraw %}{{ aws_region_for_stack if (aws_region_for_stack is defined and aws_region_for_stack != "") else "us-east-1" }}{% raw %}{% endraw %}{% if install_claude_cli %}{% raw %} | |
| - ANTHROPIC_API_KEY=${ANTHROPIC_API_KEY}{% endraw %}{% endif %}{% raw %} |
Closed
Merged
Merged
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Message thread
#98
Why is this change necessary?
Add ability to enable Claude Code
How does this change address the issue?
Adds it as a question and if so, then adds it to the devcontainer installation
What side effects does this change have?
None
How is this change tested?
N/A
Other
Bumped some other library versions
Summary by CodeRabbit