Conversation
| {% endraw %}{% if use_codecov %}{% raw %} - name: Upload coverage to Codecov | ||
| # only upload coverage from fastest job | ||
| if: matrix.JOB_MATCHING_DEV_ENV == true | ||
| if: matrix.JOB_MATCHING_DEV_ENV == true && ${{ github.actor != 'dependabot[bot]' }} # dependabot by default doesn't have access to the necessary secret...and dependabot should never be changing coverage anyway so it's fine not uploading it |
There was a problem hiding this comment.
[nitpick] Consider simplifying the condition by directly using matrix.JOB_MATCHING_DEV_ENV if it's a boolean. Also, ensure that the combined expression's evaluation order is as intended; wrapping expressions in parentheses for clarity may improve maintainability.
Suggested change
| if: matrix.JOB_MATCHING_DEV_ENV == true && ${{ github.actor != 'dependabot[bot]' }} # dependabot by default doesn't have access to the necessary secret...and dependabot should never be changing coverage anyway so it's fine not uploading it | |
| if: (matrix.JOB_MATCHING_DEV_ENV && ${{ github.actor != 'dependabot[bot]' }}) # dependabot by default doesn't have access to the necessary secret...and dependabot should never be changing coverage anyway so it's fine not uploading it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it can't access secret