Skip to content

Don't upload codecov for dependabot runs #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejfine merged 1 commit into from
May 9, 2025
Merged

Don't upload codecov for dependabot runs #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion template/.github/workflows/ci.yaml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:

{% endraw %}{% if use_codecov %}{% raw %} - name: Upload coverage to Codecov
# only upload coverage from fastest job
if: matrix.JOB_MATCHING_DEV_ENV == true
if: matrix.JOB_MATCHING_DEV_ENV == true && ${{ github.actor != 'dependabot[bot]' }} # dependabot by default doesn't have access to the necessary secret...and dependabot should never be changing coverage anyway so it's fine not uploading it
Copy link

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider simplifying the condition by directly using matrix.JOB_MATCHING_DEV_ENV if it's a boolean. Also, ensure that the combined expression's evaluation order is as intended; wrapping expressions in parentheses for clarity may improve maintainability.

Suggested change
if: matrix.JOB_MATCHING_DEV_ENV == true && ${{ github.actor != 'dependabot[bot]' }} # dependabot by default doesn't have access to the necessary secret...and dependabot should never be changing coverage anyway so it's fine not uploading it
if: (matrix.JOB_MATCHING_DEV_ENV && ${{ github.actor != 'dependabot[bot]' }}) # dependabot by default doesn't have access to the necessary secret...and dependabot should never be changing coverage anyway so it's fine not uploading it

Copilot uses AI. Check for mistakes.
uses: codecov/codecov-action@v5.1.1
with:
files: ./coverage.xml
Expand Down