Windows support#27
Merged
billbrod merged 8 commits intoLabForComputationalVision:mainfrom Dec 18, 2023
WardBrian:feature/windows-support
Merged
Windows support#27billbrod merged 8 commits intoLabForComputationalVision:mainfrom WardBrian:feature/windows-support
billbrod merged 8 commits intoLabForComputationalVision:mainfrom
WardBrian:feature/windows-support
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 69.70% 69.72% +0.02%
==========================================
Files 19 19
Lines 1459 1460 +1
Branches 328 328
==========================================
+ Hits 1017 1018 +1
Misses 348 348
Partials 94 94 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I've just added the ability to run the |
billbrod
approved these changes
Dec 18, 2023
Member
billbrod
left a comment
There was a problem hiding this comment.
This is great, thanks for putting this together!
Contributor
Author
This was referenced Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@billbrod - I had some time after lunch and it ended up not being that hard to wrap up. Here's my first attempt.
This PR enables the package to be built and used on Windows with the Microsoft compiler. It supersedes #20.
This required two changes to the C source:
Extensionobject to build the C code, a function namedPyInit_wrapConvmust exist solink.exedoesn't fail. Since we don't directlyimportthis library, it is just a dummy stub.__declspec(dllexport). This is done by way of thePYRTOOLS_EXPORTmacro, which expands to the above on Windows and nothing on *nix.There was also one small change needed in
wrapper.py, as the produced file does not end in.sobut rather has a name likewrapConv.cp312-win_amd64.pydThe remaining changes in this PR are quality-of-life, mainly around providing pre-built wheels in the
deployAction.