Update case insensitive animal history case #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Jul 27, 2022
| var updatedResults = []; | ||
|
|
||
| Ext4.each(results.rows, function (row) { | ||
| if (hasAlias) { |
There was a problem hiding this comment.
Can we consolidate these two cases? Seems like the only thing that's different is using this.aliasTable.aliasColumn vs this.aliasTable.idColumn in their first lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When doing a case insensitive search we use contains filter on the query to get case insensitive matches. This also gets ids with the search value as a substring. We need to filter these out. This is a follow up to the related PR below.
Related Pull Requests
Changes