Merge from wnprc18.3 svn r.64261 to r.65647 #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 7, 2020
bbimber
reviewed
Jul 7, 2020
Collaborator
bbimber
left a comment
bbimber
left a comment
There was a problem hiding this comment.
I realize I'm jumping in here quickly after github sent the notification and there may or may not have been more review on this. most seems fine, but there are several proposed changes in here that really should have gotten triaged.
LDK/test/src/org/labkey/test/util/external/labModules/LabModuleHelper.java
Outdated
Show resolved
Hide resolved
LDK/test/src/org/labkey/test/util/external/labModules/LabModuleHelper.java
Outdated
Show resolved
Hide resolved
laboratory/resources/web/laboratory/panel/AbstractAssayPanel.js
Outdated
Show resolved
Hide resolved
Customize source_material query directly instead of trying to mutate a locked FK lookup table Update to use new assay designer UI Migrate <javaCustomizer> syntax
bbimber
reviewed
Aug 16, 2020
LDK/test/src/org/labkey/test/util/external/labModules/LabModuleHelper.java
Outdated
Show resolved
Hide resolved
Move code from LabModuleHelper to only place that uses it, ViralLoadAssayTest Fix rate import codepath in WNPRC_EHRTest
Fix up handling of drop-downs in WNPRC misc charges entry
Consistent line spacing for parentheses
Collaborator
|
@labkey-jeckels I made one minor commit to AssayTemplatePanel to make line spacing consistent for parentheses. I also think I closed all the conversations I need as part of my review, but please let me know if i missed something i need to do to keep github happy |
|
@bbimber nope, that edit looks fine to me and is part of the PR now. |
…in 20.x line, and avoiding WNPRC_EHR query metadata if the module is deployed but not enabled in the container
…to 20.6_fb_merge_from_wnprc18.3
labkey-jeckels
approved these changes
Sep 1, 2020
Merged
bbimber
added a commit
that referenced
this pull request
Jul 24, 2024
Merge discvr-24.3 to discvr-24.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Merge from wnprc18.3 svn r.64261 to r.65647 (skipped r. 64864 & 65166 since these were backports)
Related Pull Requests
LabKey/commonAssays#200
LabKey/ehrModules#56
LabKey/onprcEHRModules#20
LabKey/platform#1370
LabKey/tnprc_billing#72