-
Notifications
You must be signed in to change notification settings - Fork 3
Merge from wnprc18.3 svn r.64261 to r.65647 #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
labkey-jeckels
merged 39 commits into
release20.6-SNAPSHOT
from
20.6_fb_merge_from_wnprc18.3
Sep 1, 2020
Merged
Merge from wnprc18.3 svn r.64261 to r.65647 #56
labkey-jeckels
merged 39 commits into
release20.6-SNAPSHOT
from
20.6_fb_merge_from_wnprc18.3
Sep 1, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 7, 2020
-Delete folders/files that should have been deleted. -Cleanup/add comments to ehr upgrade scripts.
labkey-jeckels
requested changes
Jul 8, 2020
ehr_billing/src/org/labkey/ehr_billing/notification/BillingNotification.java
Show resolved
Hide resolved
- Cleanup, optimize imports, fix bad merge - Restore 'invesLastNameCol' in ProjectEntryField.js. - Remove unused class LightCycleImportMethod.java
…dd to wnprc-modules.
labkey-jeckels
requested changes
Jul 20, 2020
Contributor
labkey-jeckels
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, pending Chad's revisions to EHRController to avoid hard-coding the React form URLs
labkey-jeckels
approved these changes
Aug 15, 2020
Contributor
labkey-jeckels
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending TeamCity happiness
Don't modify EHR schema from WNPRC_EHR scripts Update getVersion() to getSchemaVersion() Fix up schema XML files to match expected schema Fix bootstrapping for WNPRC_EHR upgrades
Customize source_material query directly instead of trying to mutate a locked FK lookup table Update to use new assay designer UI Migrate <javaCustomizer> syntax
Move code from LabModuleHelper to only place that uses it, ViralLoadAssayTest Fix rate import codepath in WNPRC_EHRTest
…e rest of the Ext3 code
…in 20.x line, and avoiding WNPRC_EHR query metadata if the module is deployed but not enabled in the container
This was referenced Aug 31, 2020
labkey-tchad
pushed a commit
that referenced
this pull request
Feb 24, 2025
- Updates related to allowing binding of DomainKind specific options/properties to a bean & generifying DomainKind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Merge from wnprc18.3 svn r.64261 to r.65647 (skipped r. 64864 & 65166 since these were backports)
Related Pull Requests
LabKey/commonAssays#200
LabKey/LabDevKitModules#38
LabKey/onprcEHRModules#20
LabKey/platform#1370
LabKey/tnprc_billing#72