Skip to content

Conversation

@labkey-bpatel
Copy link
Contributor

@labkey-bpatel labkey-bpatel commented Jul 6, 2020

Rationale

Merge from wnprc18.3 svn r.64261 to r.65647 (skipped r. 64864 & 65166 since these were backports)

Related Pull Requests

LabKey/commonAssays#200
LabKey/LabDevKitModules#38
LabKey/onprcEHRModules#20
LabKey/platform#1370
LabKey/tnprc_billing#72

-Delete folders/files that should have been deleted.
-Cleanup/add comments to ehr upgrade scripts.
- Cleanup, optimize imports, fix bad merge
- Restore 'invesLastNameCol' in ProjectEntryField.js.
- Remove unused class LightCycleImportMethod.java
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, pending Chad's revisions to EHRController to avoid hard-coding the React form URLs

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending TeamCity happiness

Don't modify EHR schema from WNPRC_EHR scripts

Update getVersion() to getSchemaVersion()

Fix up schema XML files to match expected schema

Fix bootstrapping for WNPRC_EHR upgrades
Customize source_material query directly instead of trying to mutate a locked FK lookup table

Update to use new assay designer UI

Migrate <javaCustomizer> syntax
Move code from LabModuleHelper to only place that uses it, ViralLoadAssayTest

Fix rate import codepath in WNPRC_EHRTest
@labkey-jeckels labkey-jeckels merged commit ea195b4 into release20.6-SNAPSHOT Sep 1, 2020
@labkey-jeckels labkey-jeckels deleted the 20.6_fb_merge_from_wnprc18.3 branch September 1, 2020 00:16
labkey-tchad pushed a commit that referenced this pull request Feb 24, 2025
- Updates related to allowing binding of DomainKind specific options/properties to a bean & generifying DomainKind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants