Luminex Levey-Jennings report data query performance improvements #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move ORDER BY and LIMIT from the executeSQL sql to the sort and maxRows parameters on the API call - Fix for sort order of data query in Levey-Jennings plot window - Levey-Jennings data query change how guide set range values are joined into the results (use a single join instead of joining to the GuideSetCurveFit table multiple times for each curve type) - Fix for Levey-Jennings error display so that it doesn't hardcode to expect an EC50 plot panel tab
labkey-jeckels
approved these changes
Mar 3, 2023
cnathe
added
TeamCity test review complete
and removed
needs TeamCity test review
labels
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Luminex clients with a large amount of runs/results are running into performance issues loading the Levey-Jennings report data. After investigation and reviewing execution plans from the client's server, two main drivers for the performance issues were 1) the ORDER BY and LIMIT being applied within the SQL of the executeSql call instead of as API params and 2) the number of joins we are doing to the luminex.GuideSet table to get data point ranges.
Changes