Luminex Levey-Jennings report grid improvements #595
Conversation
…id panel to LK QueryWebPart - initial dev changes for grid panel and applying filters to the data / plot - currently disabled the grid actions for "apply guide set" and "view 4PL curves"
…uide set data separately - merge together when building the plotConfig data
…and get selections accordingly
…and get selections accordingly
…ing for params panel to load
|
@labkey-klum Karl, would you mind taking the code review for this PR? Most of the changes are converting from the Ext4 grid to the LabKey DataRegion (via QueryWebpart) on the Luminex Levey-Jennings report page. We can sync up and I can demo the changes for you before you dive in. |
luminex/test/src/org/labkey/test/util/luminex/LuminexGuideSetHelper.java
Show resolved
Hide resolved
labkey-klum
left a comment
labkey-klum
left a comment
There was a problem hiding this comment.
Overall looks great and nice to migrate off of the LABKEY.editorGridPanel. Did we consider whether it made sense to migrate off of Ext3?
… set updates (part 2)
The client was pretty budget conscious, so we did not consider including that here. I'd be all for migrating the LJ report off of Ext3 (and off of Ext all together!), but I don't have a good estimate for that at this time. |
Rationale
The data grid on the Luminex Levey-Jennings report uses an Ext grid panel which limits some of the abilities that we normally see in LabKey grids, most notably the ability to page through results, customize the grid columns, and filter on arbitrary columns in the grid. This PR converts that grid to a LabKey DataRegion. This allows for the features mentioned and retains the ability to apply guide sets to data grid rows and view 4PL curve fits (for titration based reports).
Related Pull Requests
Changes