Clinical remarks data source #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-martyp
requested review from
ankurjuneja,
labkey-bpatel and
labkey-jeckels
ankurjuneja
approved these changes
Oct 7, 2021
labkey-jeckels
approved these changes
Oct 8, 2021
labkey-jeckels
requested changes
Oct 8, 2021
| } | ||
|
|
||
| @Override | ||
| protected void afterInsertUpdate(int count, BatchValidationException errors) |
Contributor
There was a problem hiding this comment.
For completeness should hook into deleteRows() as well. truncateRows() gets called when the whole table is being cleared, but won't be invoked for individual rows being deleted.
Contributor
Author
There was a problem hiding this comment.
Good call, added.
labkey-jeckels
approved these changes
Oct 8, 2021
labkey-tchad
pushed a commit
that referenced
this pull request
Feb 24, 2025
* SND/Packages schema * SubjectId, Date, SequenceNum * EventData.objectid column * objectid FK * Filter on eventdata. Add qcstate. * Categories schema * Categories schema * Avoid lookup joins for perf * Bump schema versions to 25.000 (#248) * Remove commented out code --------- Co-authored-by: Marty Pradere <martyp@labkey.com> Co-authored-by: Adam Rauch <adam@labkey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Clinical remarks categories value can be an integer so try to use title if it's available, then fall back to value. Also refresh EHR data entry cache when EHR lookup sets are updated.
Related Pull Requests
Changes