Breeder and Clinical Remarks ETL and reporting #47
Conversation
labkey-martyp
requested review from
ankurjuneja,
labkey-bpatel and
labkey-jeckels
| WHERE evtEvtGrp.EVENT_GROUP_ID = 56 | ||
| -- 56 Breeder | ||
|
|
||
| GROUP BY anmEvt.ANIMAL_EVENT_ID, |
There was a problem hiding this comment.
Don't see any aggregate column, Is this group by needed?
There was a problem hiding this comment.
No, removed from both source queries. There are a few other source queries with group bys but no aggregates, wasn't sure if there were duplicate row issues in the source data.
| @@ -0,0 +1,4 @@ | |||
| SELECT core.executeJavaUpgradeCode('reloadStudy'); | |||
| SELECT core.executeJavaUpgradeCode('etl;{NIRC_EHR}/breeder'); | |||
| SELECT core.executeJavaUpgradeCode('etl;{NIRC_EHR}/ehr_lookups'); | |||
There was a problem hiding this comment.
I think we might need to truncate ehr_lookups and run.
| @@ -0,0 +1,4 @@ | |||
| SELECT core.executeJavaUpgradeCode('reloadStudy'); | |||
| SELECT core.executeJavaUpgradeCode('etl;{NIRC_EHR}/breeder'); | |||
| SELECT core.executeJavaUpgradeCode('etl;{NIRC_EHR}/ehr_lookups'); | |||
There was a problem hiding this comment.
| SELECT core.executeJavaUpgradeCode('etl;{NIRC_EHR}/ehr_lookups'); | |
| SELECT core.executeJavaUpgradeCode('etl;{NIRC_EHR}/ehr_lookups;truncate'); |
There was a problem hiding this comment.
Good call. Updated
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Looks OK to me with Ankur's suggestions. Per our discussion, would be great to get the lookup sets cache to auto-clear via a DataIterator and/or QueryUpdateService hook
@labkey-jeckels Added cache clearing in this PR, LabKey/ehrModules#250 |
Rationale
Incremental ETLs migrating Breeder and Comments (Clinical Remarks) into datasets. Update reporting including clinical history for clinical remarks.
Related Pull Requests
LabKey/ehrModules#250
Changes