log non-date and non-string type date values #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else { | ||
| if (val['getTime']){ | ||
| normalizedVal = new Date(val.getTime()); | ||
| console.log('EHR trigger script is being passed a date with value: ' + val); |
Contributor
There was a problem hiding this comment.
This will log to the console (an improvement over the current behavior) and then fail the job with the same unhelpful error message.
I've asked Matthew to share the full log file. I checked the recording but he didn't scroll down quite far enough to show the root exception during the screensharing yesterday.
Contributor
Author
There was a problem hiding this comment.
This will give us the value of the date which we were eyeballing in granite and couldn't find.
Contributor
|
Does the platform PR effectively make this logging redundant? |
Contributor
Author
|
I think this PR will be useful for looking into the failures of locations ETL, the platform PR will log the error messages for arrivals ETL. |
labkey-jeckels
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
It is hard to determine the value of date that does not get normalized during ETLs. This change logs such values which are of type other than string and date.