log row values when exception during script execution #2704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
requested changes
Oct 21, 2021
labkey-adam
approved these changes
Nov 3, 2021
Contributor
Author
|
@labkey-jeckels thanks for looking into this, github is not letting me merge until you approve the requested chnages. |
labkey-jeckels
approved these changes
Nov 4, 2021
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
I merged release21.7-SNAPSHOT into the ehrModules FB with the same name so that we can get the test results prior to merging.
I'm not sure that the ehrModules change will be that valuable with this new, centralized logging, but it shouldn't do any harm either so I approved it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Log the row values when there is an exception during server side trigger script execution.
Related Pull Requests