Remove support for useEmbeddedTomcat, tomcat-lib, and log4j2.xml #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2024
Merged
Merged
Contributor
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
I think there are some methods and/or properties that
labkey-tchad
requested changes
Sep 4, 2024
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
We can probably get rid of the entire distributionResources directory and any tasks that publish it. The distributionResources/embedded is just an incomplete duplicate of server/configs/webapps/embedded. The files here are only used if the corresponding files from the server repo are missing -- which should never happen. Everything else in distributionResources is for standalone tomcat.
Co-authored-by: Trey Chadick <tchad@labkey.com>
labkey-susanh
approved these changes
Sep 4, 2024
Contributor
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
Might still be able to clean up that TomcatExtension, but I'm going to leave that for Trey to answer (and we can do it later if we find it's not used).
src/main/groovy/org/labkey/gradle/plugin/extension/TomcatExtension.groovy
Show resolved
Hide resolved
labkey-tchad
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
No need to handle standalone builds