Remove useEmbeddedTomcat property and other support for standalone #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
approved these changes
Sep 4, 2024
labkey-susanh
approved these changes
Sep 4, 2024
labkey-tchad
reviewed
Sep 4, 2024
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Can probably get rid of TestProperties.getTomcatHome() as well
Contributor
Author
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Support for the
useEmbeddedTomcatproperty is being removed in the next Gradle Plugin versionRelated Pull Requests