Add audit logging for file fields and renaming of files #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
cnathe
approved these changes
Jul 28, 2025
| return null; | ||
| } | ||
| let url = AppURL.create('audit', id); | ||
| const activeTab = caseInsensitive(_row, 'EventType')?.value.toLowerCase(); |
Contributor
There was a problem hiding this comment.
curious why the use of toLowerCase here? could / should that be done on the other side when we use this param?
Contributor
Author
There was a problem hiding this comment.
It's done because that's what the audit event constants have for their values. which are what we use for the ids in the QueryConfigMap, which is what we match against for determining the active tab. Could be done where we pass in the value to the TabbedGridPanel to be slightly more robust. I'll make it so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When files are uploaded to store on the file system, we need to avoid name collisions and thus must sometimes rename files. We do this by appending counter suffixes to the file name base. For better accountability, we want to now add audit records for these file uploads and renames. See the related PRs for more info.
Related Pull Requests
Changes
TransactionAuditIdRendererfor displaying link to page of audit records associated with a transaction idAuditDetailsto show original file name values in tooltip when appropriate