Add audit logging for file fields and renaming of files #6869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iginal names along with modified names
…ails for original data
…events are tied together
This was referenced Jul 23, 2025
cnathe
requested changes
Jul 28, 2025
experiment/src/org/labkey/experiment/api/SampleTypeServiceImpl.java
Outdated
Show resolved
Hide resolved
cnathe
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When files are uploaded to store on the file system, we need to avoid name collisions and thus must sometimes rename files. We do this by appending counter suffixes to the file name base. For better accountability, we want to now add audit records for these file uploads and renames. This includes:
We add the original file name as well as a transactionId to the
FileSystemAuditEventin order to record the given data and to provide a way to link together the file events with the events from the appropriate domain.Related Pull Requests
Changes
findUniqueFileNameand relatives fromAssayFileWritertoFileUtilFileSytemAuditEventto include transactionId and the originally provided name