Additional AuditEvents and helper methods for checking file audit logs #2584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnathe
approved these changes
Jul 28, 2025
| List<String> columnNames = expectedValues.get(0).keySet().stream().map(Object::toString).toList(); | ||
| List<Map<String, Object>> events = getAuditLogsForTransactionId(containerPath, auditEventName, columnNames, transactionId, ContainerFilter.CurrentAndSubfolders); | ||
| assertEquals("Unexpected number of events for transactionId " + transactionId, rowCount, events.size()); | ||
| for (int i = 0; i < rowCount; i++) |
Contributor
There was a problem hiding this comment.
do you need the rowCount param here? could you just use the expectedValues list size?
Contributor
Author
There was a problem hiding this comment.
For current usages, it's not needed. I was leaving open the possibility that you may not want to verify the data in all the rows, but ended up not using it. Removing rowCount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
See related PR
Related Pull Requests
Changes
FILE_SYSTEM_EVENTandASSAY_AUDIT_EVENTtoAuditEventsenumcheckAuditEventValuesForTransactionIdfor expected rows with different values.