Skip to content

Adding PMIC project files. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kollil merged 10 commits into from
Mar 31, 2021
Merged

Adding PMIC project files. #122

kollil merged 10 commits into from
Mar 31, 2021

Conversation

@kollil
Copy link
Collaborator

@kollil kollil commented Mar 19, 2021

Rationale

Adding new project files for PMIC.

Related Pull Requests

Changes

@kollil
Copy link
Collaborator Author

kollil commented Mar 19, 2021

Josh, The changes are being tested on prime test instance. Please approve them.

@kollil kollil requested a review from labkey-jeckels March 19, 2021 23:46
@kollil
Copy link
Collaborator Author

kollil commented Mar 19, 2021

Josh, The changes are being tested in the test instance. Please approve them to put them in uat and then in production.

Thanks

@labkey-jeckels
Avoid using "IF EXISTS" syntax, unsupported by older SQL Server versi…
ac6d76e 
…ons that are still supported and tested on TeamCity
labkey-jeckels
labkey-jeckels requested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments/questions, and one note on a small adjustment I made to the SQL upgrade script

@kollil
Copy link
Collaborator Author

kollil commented Mar 23, 2021

Josh, Could you please review the changes I made.
Thanks
Lakshmi

@kollil
Copy link
Collaborator Author

kollil commented Mar 31, 2021

Josh, I am ready to merge my changes into release20.11-SNAPSHOT from 20.11_fb_PMIC.
Before I click the Squash & Merge button, please confirm all the changes (until my recent build #132) will be included in the default branch.

Thanks
Lakshmi

@labkey-jeckels
Copy link
Contributor

labkey-jeckels commented Mar 31, 2021

Yes, they will all be included. You can always review the changes being merged by going to the Files Changed tab here in the pull request.

https://github.com/LabKey/onprcEHRModules/pull/122/files

@kollil kollil merged commit a2e796a into release20.11-SNAPSHOT Mar 31, 2021
@kollil kollil deleted the 20.11_fb_PMIC branch March 31, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kollil @labkey-jeckels