20.11 fb pmic updates #132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding PMIC project files. * Avoid using "IF EXISTS" syntax, unsupported by older SQL Server versions that are still supported and tested on TeamCity * Removed the containerid from the queries * Updated PMIC files and adding housing alert related files. * Added the PMIC section to the Queues * Fixed the file name typo and updated the xml file with PMIC_Reference_Data * Added "Go" statement before the CREATE statements * Added a new alert called PMIC services alert. Updated the ONPRC_EHRModule.java file, added a new sql file and updated ColonyAlertsNotification.java file. * New ETL process added to schedule housing transfer alert process * Added the "GO" statements before and after the stored proc. Co-authored-by: labkey-jeckels <jeckels@labkey.com>
Hid the center project and credit To fields from the PMIC data entry panels.
Contributor
|
@kollil I think that you hadn't pulled the latest from release20.11-SNAPSHOT when you created this branch. Hence, it's showing all of the files from your original PMIC feature branch. Please recreate the branch. You can use this URL to get a patch that contains what I think are the only edits you intended to make: It looks like you re-introduced the ContainerIDs in the WHERE clauses. As I said in my earlier review, we don't want to embed the EntityIDs like that as it will make it impossible to test on LabKey dev machines, etc. You may be able to query based on a container name or other criteria to get the same results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
PMIC Scheduler queries are updated and removed two fields from the data entry panels.
Related Pull Requests
Changes