Overridable Role Impersonation #5729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
labkey-adam
requested changes
Aug 1, 2024
Contributor
labkey-adam
left a comment
labkey-adam
left a comment
There was a problem hiding this comment.
Most of these changes go away if the other PR uses contextual roles
labkey-adam
reviewed
Aug 1, 2024
| public RoleSet getRoles() | ||
| { | ||
| return _roles; | ||
| } |
Contributor
There was a problem hiding this comment.
I think this is the only change that's necessary. Maybe the class has to be public as well to do the instanceof check.
labkey-adam
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
SND uses non-container based permissions. These are tested, both manually and automated, using role impersonation. The recent change to role impersonation makes that testing not possible. This change allows the role impersonation context to be overridden.
Related Pull Requests
Changes