Skip to content

Overridable Role Impersonation #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-martyp merged 2 commits into from
Aug 6, 2024
Merged

Overridable Role Impersonation #5729

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c49be4
Allow overriding RoleImpersonation behavior
labkey-martyp Aug 1, 2024
ebf6210
CR refactor
labkey-martyp Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion api/src/org/labkey/api/security/impersonation/RoleImpersonationContextFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ public static Stream<Role> getValidImpersonationRoles(Container c, User user)
.filter(role -> !role.isPrivileged() || canImpersonatePrivilegedRoles);
}

private static class RoleImpersonationContext extends AbstractImpersonationContext
public static class RoleImpersonationContext extends AbstractImpersonationContext
{
private final RoleSet _roles;
private final String _cacheKey;
Expand Down Expand Up @@ -298,5 +298,10 @@ public void addMenu(NavTree menu, Container c, User user, ActionURL currentURL)
super.addMenu(menu, c, user, currentURL);
RoleImpersonationContextFactory.addMenu(menu, "Adjust Impersonation");
}

public RoleSet getRoles()
{
return _roles;
}
Copy link
Contributor

@labkey-adam labkey-adam Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only change that's necessary. Maybe the class has to be public as well to do the instanceof check.

}
}