Fix SQL Server timestamp handling with non-US date formats #5805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Aug 26, 2024
bigiron/src/org/labkey/bigiron/mssql/MicrosoftSqlServer2016Dialect.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
On SQL Server with a non-US language set (which sets the date format to "dmy"), all Timestamp JDBC parameters are sent in a format that SQL Server parses incorrectly. This leads to incorrect data (when the day of the month is <= 12) or exceptions (when day of the month > 12). https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=51129