Skip to content

Conversation

@labkey-tchad
Copy link
Member

Rationale

Using non-standard code locations interferes with Gradle's ability to build efficiently (by skipping unnecessary build steps and by caching build results).

Related Pull Requests

  • N/A

Changes

  • Move client-side source code into standard src/client directory

@labkey-tchad
Copy link
Member Author

labkey-tchad commented Nov 3, 2022

@dnicolalde @csebranek If this looks good to you, I recommend applying the same change to your fork so that I can re-enable build caching on TeamCity and to avoidminimize future merge conflicts.
Note: The TeamCity failures aren't particular to this branch.

Copy link
Collaborator

@csebranek csebranek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkey-tchad changes look good to me. I also moved a few more client side files over related to the water monitoring config. And restored water monitoring config that was unintentionally removed in this merge.

@labkey-tchad labkey-tchad merged commit c7aa316 into release22.7-SNAPSHOT Nov 7, 2022
@labkey-tchad labkey-tchad deleted the 22.7_fb_clientSrcDirectories branch November 7, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants