Make NPM build output work with Gradle cache #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Nov 14, 2022
Contributor
|
@labkey-tchad Thank you for doing this work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The client sources are in the correct place now but the NPM build output location isn't what Gradle expects (
resources/web/wnprc_ehr/geninstead ofresources/web/WNPRC_EHR/gen). Similar forAnimalRequests. I've moved theAnimalRequestsoutput to the typical location but it was simpler to teach Gradle about the output location forWNPRC_EHRsince there is so much non-generated code referencing the current location.Related Pull Requests
Changes
AnimalRequestsNPM output