feat(settings): per-account overrides modal — fixes panel-stacking (closes #122, #116)

[cristim]

Closes #122. Closes #116.

The bug, in one screenshot's worth

Two AWS accounts: AWS 540659244915 and CUDly host (909626172446). User clicks Overrides on 540… → empty-state auto-opens the create modal → creates an aws/ec2 override with Partial Upfront / 34% coverage. Modal closes; the inline panel under the accounts table now shows [Add override] and the new row.

User then clicks Overrides on 909…. That account's panel also opens, appended after 540…'s panel. Result: two panels stacked under the table with no titles. The aws/ec2 row visually attaches to whichever account is closer on screen, two unscoped Add override buttons appear, and "No service overrides yet for this account." text floats between them with no indication of which account.

The rework

All four CRUD operations move into a per-account modal keyed by an explicit title (Service overrides for {account.name} ({external_id})). The accounts table loses the inline expandable panel entirely.

• List: the existing overrides table renders inside the modal body. Same columns, same Reset button per row, same inline payment <select> from ux(settings): add payment option selector to AWS account overrides modal #72.
• Create: the existing override-modal from feat(settings): create-override modal for AWS account overrides (closes #104) #106 stacks on top of the new account-overrides-modal when the user clicks Add override. Save reloads the parent's list; cancel leaves the parent open with the existing rows.
• Edit-payment: PR ux(settings): add payment option selector to AWS account overrides modal #72's inline selector is unchanged in behaviour, just rendered inside the modal body now.
• Delete (Reset): same confirmDialog flow as before.

renderAccountsList no longer creates per-row panels, no longer collects them in a panels[] array, and no longer appends them after the table. The whole inline-panel scaffolding is gone.

Empty-state UX is preserved: an AWS account with zero overrides still auto-opens the inner create modal, so users land directly on the form in 1 click — no regression vs #106.

A defensive tweak: closeAccountOverridesModal also closes the inner create modal, so a programmatic close (or future ESC-to-close from #115) doesn't leave an orphan modal whose Save would target a hidden parent.

What this closes / pairs with

• Closes ux(settings): rework Overrides into a per-account modal (CRUD all four operations there) #122 — this PR is the rework.
• Closes ux(settings): override modal silently swaps account context when reopened #116 — silent-context-swap bug. The new modal's title makes the account context unambiguous, and the test switching accounts swaps the modal title locks it in.
• Pairs with ux(settings): inline edit Term/Coverage + Enabled toggle on existing override rows (V2 of #72) #110 — the inline term/coverage/enabled editing on existing rows lives inside the new modal naturally.
• Pairs with ux(settings): create-override modal for Azure and GCP accounts (V2 of #106) #109 — Azure/GCP modal V2 threads through this same modal once the per-provider service/payment options are wired.
• Inherits a11y(settings): focus management, focus trap, and ESC-to-close on all modals #115 — focus-trap / ESC-to-close / return-focus a11y is still its own sweep across all modals.

Test plan

• npx jest src/__tests__/settings-accounts.test.ts — 36 existing tests (PR ux(settings): add payment option selector to AWS account overrides modal #72's "AWS payment selector" + PR feat(settings): create-override modal for AWS account overrides (closes #104) #106's "Create-override modal") rewritten to look for #account-overrides-modal-body instead of .account-overrides-panel. Plus 4 new in an "Account overrides modal" block: title binds to account, switching accounts swaps the title (locks in ux(settings): override modal silently swaps account context when reopened #116's fix), Close clears body, regression guard that .account-overrides-panel no longer renders. 40/40 pass.
• npx jest — full frontend suite (1273 tests) green.
• npm run typecheck clean.
• npm run build (production webpack) clean.
• Smoke after deploy: open Settings → Accounts → click Overrides on different accounts back-to-back; confirm the modal opens with the right title, the Add override button works, no inline panel appears below the accounts table.

🤖 Generated with claude-flow

[coderabbitai]

Warning

Rate limit exceeded

@cristim has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 42 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 457360ff-27f7-4724-be5d-fbbe0d8bebd8

📥 Commits

Reviewing files that changed from the base of the PR and between 89e503a and 8be0f56.

📒 Files selected for processing (3)

• frontend/src/__tests__/settings-accounts.test.ts
• frontend/src/index.html
• frontend/src/settings.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/overrides-modal-rework

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cristim]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.