chore(settings): drop stale .account-overrides-panel cleanup selector#125
Merged
cristim merged 1 commit intoApr 27, 2026
Conversation
PR #124 (issue #122) moved per-account overrides into a modal and deleted the inline `.account-overrides-panel` element from the accounts table. The cleanup selector at renderAccountsList top still listed it, which is dead — no such element ever exists now. Drop the class from the querySelectorAll list and explain in the comment that overrides moved to the modal so a future reader doesn't restore the reference. No behaviour change. Tests + typecheck + build still green.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cristim
added
triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #124. The renderAccountsList cleanup selector still listed the
.account-overrides-panelclass even though that element no longer exists post-rework. One-line dead-code removal.Tests: full suite (1273) green; typecheck + build clean.
🤖 Generated with claude-flow