Skip to content

chore(settings): drop stale .account-overrides-panel cleanup selector #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Apr 27, 2026
Merged

chore(settings): drop stale .account-overrides-panel cleanup selector #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions frontend/src/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,13 @@ function renderAccountsList(
provider: AccountProvider,
filter: AccountStatusFilter = 'all'
): void {
// Remove prior rendered rows (Overrides panels are sibling elements,
// banner lives in a separate className managed by renderSelfAccountBanner).
// Remove prior rendered rows (banner lives in a separate className
// managed by renderSelfAccountBanner). `.account-overrides-panel` used
// to be cleaned up here too — it was the inline expandable panel each
// account carried before #122/#124 moved overrides into a per-account
// modal. No such elements exist anymore.
container.querySelectorAll(
'.accounts-table, .account-overrides-panel, .accounts-empty, .status-chip-row'
'.accounts-table, .accounts-empty, .status-chip-row'
).forEach(el => el.remove());

if (!accounts || accounts.length === 0) {
Expand Down