fix(commitmentOptions): align savingsplans key (CodeRabbit nitpick sweep)

[cristim]

Summary

Addresses the only live CodeRabbit finding across all open/closed PRs (24–39, 52–54).

• CodeRabbit flagged a key mismatch on PR #30: SERVICE_FIELDS in settings.ts:32 uses service: 'savingsplans' while commitmentConfigs in commitmentOptions.ts:58 registered the AWS entry under 'savings-plans'. Any lookup through isValidCombination/getCommitmentConfig with the non-hyphenated identifier silently fell through to _default.
• CodeRabbit suggested renaming SERVICE_FIELDS to 'savings-plans', but that value also flows into api.updateServiceConfig(provider, service, cfg) at settings.ts:1443 — the service column is the DB primary key in the service_configs table, existing rows are ('aws', 'savingsplans'), and renaming without a migration would silently create duplicate rows. The dropdown at index.html:112,703 (<option value="savingsplans">) and the backend CLI flag (cmd/main.go:92) also use the non-hyphenated form.
• Safer fix: rename the commitmentConfigs.aws key to savingsplans so every frontend call site — the SERVICE_FIELDS loop, the plan-form dropdown, and any direct lookup — resolves to the Savings-Plans-specific config. Update the two test cases.

Scope of the PR

PR	Finding	Status
#52	Actionable: guard catch block against non-Error throws	✅ already fixed in db429fe
#52	Nitpick: btn.disabled vs setAttribute, drop dead ?? 'Refresh'	✅ already fixed in db429fe
#30	Outside-diff: savingsplans vs savings-plans key mismatch	✅ fixed here
#30	Nitpick: double Promise.resolve() in settings.test.ts:854	⤴ applies only to code on PR #30's branch
#30	Advisory: memorydb absent from SERVICE_FIELDS	⤴ forward-looking (no MemoryDB card exists yet)
All other PRs (24–29, 31–39, 53, 54, 3, 4)	"No actionable comments" from CodeRabbit	—

Test plan

• jest — 1244/1244 pass (all 35 suites)
• tsc --noEmit — clean
• grep confirms no remaining 'savings-plans' references in frontend code outside Go backend constants (pkg/common/types.go:49 is the backend canonical — unchanged, and execution.go:384 already accepts both forms)
• Smoke test on the deployed AWS Lambda URL once CI finishes

🤖 Generated with claude-flow

Summary by CodeRabbit

• Chores
  • Updated AWS savings plans configuration handling to improve consistency and reliability.

[cristim]

@coderabbitai review

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 110d5d90-d7b6-4310-841c-df9591a4324e

📥 Commits

Reviewing files that changed from the base of the PR and between db429fe and e0260d2.

📒 Files selected for processing (2)

• frontend/src/__tests__/commitmentOptions.test.ts
• frontend/src/commitmentOptions.ts

---

📝 Walkthrough

Walkthrough

The AWS Savings Plans service identifier is updated from 'savings-plans' to savingsplans in the configuration implementation and corresponding test files to align with AWS naming conventions.

Changes

Cohort / File(s)	Summary
Savings Plans Service Identifier Update frontend/src/commitmentOptions.ts, frontend/src/__tests__/commitmentOptions.test.ts	Renamed the service configuration key for AWS Savings Plans from 'savings-plans' to savingsplans across implementation and test files, including updated test descriptions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A simple rename, so clean and bright,
From hyphens lost to letters tight,
savingsplans now stands its ground,
Where AWS conventions are found,
Configuration unified, tests aligned—perfection found! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main change: aligning the savingsplans key in commitmentOptions from 'savings-plans' to 'savingsplans' to fix a key mismatch across the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/coderabbit-service-key

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.