Skip to content

fix(commitmentOptions): align savingsplans key (CodeRabbit nitpick sweep) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Apr 25, 2026
Merged

fix(commitmentOptions): align savingsplans key (CodeRabbit nitpick sweep) #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions frontend/src/__tests__/commitmentOptions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ describe('commitmentOptions', () => {
expect(config.invalidCombinations).toBeUndefined();
});

it('should return savings-plans config with all options', () => {
const config = getCommitmentConfig('aws', 'savings-plans');
it('should return savingsplans config with all options', () => {
const config = getCommitmentConfig('aws', 'savingsplans');

expect(config.terms).toHaveLength(2);
expect(config.payments).toHaveLength(3);
Expand Down Expand Up @@ -198,9 +198,9 @@ describe('commitmentOptions', () => {
expect(isValidCombination('aws', 'ec2', 3, 'all-upfront')).toBe(true);
});

it('should return true for all savings-plans combinations', () => {
expect(isValidCombination('aws', 'savings-plans', 1, 'no-upfront')).toBe(true);
expect(isValidCombination('aws', 'savings-plans', 3, 'no-upfront')).toBe(true);
it('should return true for all savingsplans combinations', () => {
expect(isValidCombination('aws', 'savingsplans', 1, 'no-upfront')).toBe(true);
expect(isValidCombination('aws', 'savingsplans', 3, 'no-upfront')).toBe(true);
});
});

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/commitmentOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const commitmentConfigs: Record<string, Record<string, CommitmentConfig>> = {
payments: AWS_PAYMENTS
},
// Savings Plans - all options available
'savings-plans': {
savingsplans: {
terms: STANDARD_TERMS,
payments: AWS_PAYMENTS
},
Expand Down