Skip to content

Expand ColumnWidths on longer times#28

Merged
wooferzfg merged 6 commits intoLiveSplit:masterfrom
AlexKnauth:ColumnWidths
Aug 23, 2025
Merged

Expand ColumnWidths on longer times#28
wooferzfg merged 6 commits intoLiveSplit:masterfrom
AlexKnauth:ColumnWidths

Conversation

@AlexKnauth
Copy link
Contributor

@AlexKnauth AlexKnauth commented Aug 3, 2025

Fixes the Splits component portion of LiveSplit/LiveSplit#2616

Testing:

  • Test with longer times
  • Test with longer deltas
    • Far behind deltas with fast comparison, slow times: expands for everything except live deltas
    • Far ahead deltas with slow comparison, fast times

@AlexKnauth AlexKnauth marked this pull request as ready for review August 5, 2025 14:45
@AlexKnauth
Copy link
Contributor Author

I've recorded a demonstration here: https://www.youtube.com/watch?v=VRA9HMViMCk

It expands the Column Widths to accommodate everything except live deltas. I view that as fine, since live deltas are temporary. Either the live delta can shrink to fit within the existing column width by the time it splits, or after it splits the live delta will become a normal delta, and the column width will grow to accommodate that normal delta.

@AlexKnauth
Copy link
Contributor Author

I've recorded a new demonstration video after better adjusted widths: https://www.youtube.com/watch?v=C_TOahgVMWo

This one includes both ahead deltas and behind deltas, and shows both Splits and Subsplits components.

ColumnWidths.Add((0, 0f, 0f));
}

TimeSpan longest_time = new TimeSpan(9, 0, 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use camelCase instead? I don't usually see snake_case in C#

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok done.

@wooferzfg wooferzfg merged commit f8b6474 into LiveSplit:master Aug 23, 2025
@AlexKnauth AlexKnauth deleted the ColumnWidths branch August 23, 2025 19:09
wooferzfg added a commit that referenced this pull request Oct 4, 2025
Oekn5w added a commit to Oekn5w/LiveSplit.Splits that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants