Custom Variables in Splits: Fix column overlap on higher accuracies#29
Custom Variables in Splits: Fix column overlap on higher accuracies#29Oekn5w wants to merge 2 commits intoLiveSplit:masterfrom
Conversation
|
I've constructed the commit so that original code ownership might hopefully be preserved while being mergable |
| protected TimeAccuracy CurrentAccuracy { get; set; } | ||
| protected TimeAccuracy CurrentDeltaAccuracy { get; set; } | ||
| protected bool CurrentDropDecimals { get; set; } |
There was a problem hiding this comment.
Why are these new properties necessary? Is there a reason why just using Settings.SplitTimesAccuracy, Settings.DeltasAccuracy, and Settings.DropDecimals wouldn't work properly in some case?
There was a problem hiding this comment.
I guess the alternative would be to make a new SplitTimeFormatter and a new DeltaSplitTimeFormatter on every tick instead of just on the ticks where one of the settings changed
There was a problem hiding this comment.
Okay yeah, what you're doing seems better, and it's what the LabelsComponent was doing before, and what the SplitComponent was doing and is still doing, so it fits in well with that
There was a problem hiding this comment.
Yeah, my initial idea was to modify the timeformatters, but I didn't actually check if that is possible. I just copied over the things from the other components once I noticed how they are doing it.
2 participants
#28 missed to account for the accuracy settings during width determination.
I've copied over the code from the
SplitComponentthat handles the rendering of the times/deltasResolves the issue reported in LiveSplit/LiveSplit#2633 and others (closed because of reverting) and resolves LiveSplit/LiveSplit#2616.
Tested by cycling the accuracy with 10+ hours splits and 9+ hours deltas.
No custom variables available atm to test those.