[WIP] Translate chat messages with Google #38
Conversation
2022-01-13.23-06-30.mp4 |
2022-01-14.23-27-25.mp4 |
|
feel free to make changes as u wish instead of giving feedback lol |
|
Discovered a critical issue: this gets stuck in an infinite loop when a user scrubs the video. I'll look into it |
|
added animations 2022-01-15.13-03-25.mp4 |
|
This isn't ready yet because this requires the settings panel to be merged first + I still haven't added the ability to select languages. I'll do that after the settings pane is merged |
2022-01-23.22-46-50.mp4 |
KentoNishi
requested review from
ChrRubin and
r2dev2
and removed request for
ChrRubin
r2dev2
left a comment
r2dev2
left a comment
There was a problem hiding this comment.
Can you make the options user interface scroll down when you select "translate messages" and also when u click the dropdown because I found it very confusing why it wasn't translated and why there were no immediately available settings to click when I selected "translate messages?"
Also, I think that highlighting the translated message may not be the best UI choice as it draws excessive attention to messages that are in a diff language. Perhaps it might be better to just change the text color to blue for translations.
A lot of messages aren't being translated right now either in a kanata stream.
r2dev2
left a comment
r2dev2
left a comment
There was a problem hiding this comment.
Congratulations to @KentoNishi for being kfp.
| type: 'popup', | ||
| height: 300, | ||
| width: 600 | ||
| height: 420, |
ChrRubin
left a comment
ChrRubin
left a comment
There was a problem hiding this comment.
Not sure if we wanna translate deleted messages, since that message is localized by YT locale anyway.
src/ts/storage.ts
Outdated
| @@ -1,11 +1,38 @@ | |||
| import { webExtStores } from 'svelte-webext-stores'; | |||
| import { readable, writable } from 'svelte/store'; | |||
| import { getClient, IframeTranslatorClient } from 'iframe-translator'; | |||
There was a problem hiding this comment.
IframeTranslatorClient should be imported as type so builds don't show warnings about non-existent export.
|
@ChrRubin agane plz thx |
Using https://github.com/KentoNishi/iframe-translator