Improved welcome message #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
oh this should be merged after #38 btw |
KentoNishi
requested review from
ChrRubin and
r2dev2
and removed request for
ChrRubin
Member
Author
r2dev2
approved these changes
Feb 10, 2022
ChrRubin
requested changes
Feb 10, 2022
src/components/WelcomeMessage.svelte
Outdated
Comment on lines
50
to
52
| <a {href} class="underline text-primary-50" target="_blank"> | ||
| {name} | ||
| </a> |
Member
There was a problem hiding this comment.
Links are illegible in light mode:
Member
Author
|
ok it looks like i partially implemented last version, decided against it, and then forgot that i had that unused implementation lmfao good catch |
Member
Author
|
also just found out that this entire time i had .svelte linting disabled for both the hc and ltl repos... bru |
Member
Author
|
@ChrRubin implemented the close button, review plz thx
|
ChrRubin
approved these changes
Feb 12, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements some suggestions in #45