Add application image

[PapyKahan]

Description

Application picture feature added.

Screenshot

Issues Fixed or Closed

N/A

Type of Change

• Application image path into *_apps.json.

• Modification of GFE appimage route to send the picture to the client.

• A field has been added to the WebUI to configure image path.

• Bug fix (non-breaking change which fixes an issue)

• New feature (non-breaking change which adds functionality)

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the documentation blocks for new or existing components

[github-actions]

Pull requests must be made to the nightly branch. Thanks.

[ReenigneArcher]

Code reviewed, but not tested. Seems mostly okay at first glance. One small change requested.

Have you tested on Linux and Windows? Please check each box if you've tested.

• Windows
• Linux

[PapyKahan]

• Windows
• Linux

I don't have a linux setup now. Currently building one.

[TheElixZammuto]

Tested with Windows 11 and Moonlight-qt and Moonlight-ios with both JPG and PNG files, it works

[cgutman]

I'd be careful returning non-PNG images. They might work but it's only by luck.

All current Moonlight clients assume the image they get back will be a PNG (like GFE does). They will cache the images locally as .png files, which may confuse the APIs consuming those files if they guess the image format based on the file extension.

[ReenigneArcher]

Based on comments by @cgutman let's force the image to be PNG.

Additionally there was a typo in the word extension wherever it appeared.

[ReenigneArcher]

Reviewed.

[ReenigneArcher]

@cfajardo can you take a look at this? A user in the moonlight discord was testing and couldn't get it to return the png or even the default image (on Windows). https://discord.com/channels/352065098472488960/667129596088418344/938115637627191417

I'm also going to try to setup a test machine later to test out this PR in both linux and windows.

[PapyKahan]

@cfajardo can you take a look at this? A user in the moonlight discord was testing and couldn't get it to return the png or even the default image (on Windows). https://discord.com/channels/352065098472488960/667129596088418344/938115637627191417

I'm also going to try to setup a test machine later to test out this PR in both linux and windows.

Could you invite me to Discord channel ? I'm not able to access it.

[ReenigneArcher]

@cfajardo can you take a look at this? A user in the moonlight discord was testing and couldn't get it to return the png or even the default image (on Windows). https://discord.com/channels/352065098472488960/667129596088418344/938115637627191417
I'm also going to try to setup a test machine later to test out this PR in both linux and windows.

Could you invite me to Discord channel ? I'm not able to access it.

https://moonlight-stream.org/discord

[PapyKahan]

@cfajardo can you take a look at this? A user in the moonlight discord was testing and couldn't get it to return the png or even the default image (on Windows). https://discord.com/channels/352065098472488960/667129596088418344/938115637627191417
I'm also going to try to setup a test machine later to test out this PR in both linux and windows.

Could you invite me to Discord channel ? I'm not able to access it.

https://moonlight-stream.org/discord

Sunshine channel seems to be private. Am I right ?

[ReenigneArcher]

@cfajardo No... I think you need to select your roles in https://discord.com/channels/352065098472488960/668086277639503874

Also, I can confirm I'm not seeing images on a windows host, haven't tested linux yet.

[ReenigneArcher]

Small typo in apps_linux.json

Typo needs fixed.

[ReenigneArcher]

I appreciate your work on this PR and apologize for asking for a bunch of changes. One final change and then I'll merge the PR.