Merged
Conversation
- Add fontawesome - Add favicon - Add logo - Add support and legal links to index.html - Improve layout of index.html - Improve layout of navbar
ReenigneArcher
commented
Feb 6, 2022
ReenigneArcher
commented
Feb 9, 2022
Member
Author
ReenigneArcher
left a comment
ReenigneArcher
left a comment
There was a problem hiding this comment.
Fix .ico and css (stylesheet)
- All sizes available on separate layers
Member
Author
|
@TheElixZammuto Okay, for the fontawesome, I am serving the 3 required files manually (css, and two tff files). I've also included the other *min.css files, and other webfonts even though they are not being used (will be easier to utilize them later if needed). Tested and everything seems to be working (logo, favicon, and font-awesome icons). Also, safe to make release v0.12.0 after this PR? |
Member
|
Tested on Windows, looks okay and it works, LGTM |
TheElixZammuto
approved these changes
Feb 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
Checklist