Skip to content

Update MinecraftCom.cs#10

Closed
dogwatch wants to merge 1 commit intoMCCTeam:Indevfrom
dogwatch:patch-3
Closed

Update MinecraftCom.cs#10
dogwatch wants to merge 1 commit intoMCCTeam:Indevfrom
dogwatch:patch-3

Conversation

@dogwatch
Copy link
Contributor

No description provided.

@ORelio
Copy link
Member

ORelio commented Jul 27, 2013

OK so after reading, this allows to write messages substring by substring instead of char by char.
However this seems a bit complicated, all your previous changes made the code simpler/more efficient ^^
If you are trying to write as much text as possible at the same time, how about:

  • First of all, replace \n with ' ' if !acceptnewlines
  • Split string with '§' char as delimiter and get a string array
  • Write first substring as is, if not null or empty
  • For each other string, change console color with first char as color code
  • and write the string with first char removed to the console

@ORelio
Copy link
Member

ORelio commented Jul 27, 2013

Included this improvement in ea27740, thanks!
Used the algorithm in 5 steps described above + IO fixes, console output should be processed even faster :)

@ORelio ORelio closed this Jul 27, 2013
@dogwatch dogwatch deleted the patch-3 branch July 27, 2013 17:30
ORelio added a commit that referenced this pull request Jul 27, 2013
Added statics + check > 0 from pull #10, and small optimization in
FinalizeLogin.
@mobdon mobdon mentioned this pull request Jan 28, 2016
@GDSHoopFam GDSHoopFam mentioned this pull request Mar 20, 2019
@xTryer xTryer mentioned this pull request Apr 25, 2019
@slaapkopamy slaapkopamy mentioned this pull request May 17, 2020
2 tasks
@n00b69 n00b69 mentioned this pull request May 4, 2021
@pxlzgmng pxlzgmng mentioned this pull request Jul 13, 2021
4 tasks
breadbyte pushed a commit that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants