Skip to content

Indev#105

Closed
mobdon wants to merge 112 commits intomasterfrom
Indev
Closed

Indev#105
mobdon wants to merge 112 commits intomasterfrom
Indev

Conversation

@mobdon
Copy link

@mobdon mobdon commented Jan 27, 2016

No description provided.

ORelio and others added 30 commits March 11, 2015 18:37
Import changes from master into Indev (v1.8.2)
Bug report by doranchak (forum post no 1136)
Mono Framework does not handle CFB-8 AES encryption mode. So now MCC
will now use borrowed code from the BouncyCastle project for handling
AES when running on Mono framework, instead of using a dirty workaround
to try getting Mono encryption working. Regular .NET framework
encryption module will still be used when not running under Mono (eg on
Windows or using Wine)

Should hopefully fix all the issues encountered on Mono including #41
and finally achieve full compatibility of MCC with Mac and Linux.
Avoid crashing due to bots not properly processing text
- Save & Restore background color when needed
- Remove useless color modifications
- Fix issue #71
Might help when login/session servers take a long time to respond.
- Add prompt for Minecraft version
- Improve offline-mode command prompt
- Fix default value on parse error in protocol handler
- Fix failed to connect not showing offline prompt
Unix-Tool-Like syntax : user@host
Window title can be changed or disabled in INI file
- Better catch in proxy handler
- Better catch in StartClient (thx doranchak)
Bug report by doranchak
Thanks doranchak & FantomHD (post no.1193)
+ Add missing doc for MinecraftVersionPrompt
- Pass minecraft login failure message to AutoRelog bot (suggestion by
doranchak)
- Fix NullReferenceException in McTcpClient caused by SocketException in
ProxyHandler
- Refactor error handling code in Program.InitializeClient()
- More detailed error messages on network errors.
Add config for automated builds
Build can be configured directly on AppVeyor.
- Merge all error handling code into one method
- Fix ConsoleIO not clearing the line being typed upon reset
- Update console title upon logging in to the server
- Pass "failed to ping this IP" to AutoRelog (thx doranchak)
"Failed to ping this IP" also caused "Failed to determine server
version" error, calling HandleFailure() twice.
Fix concurrency issues by using proper locks
Indentation was intentionally left the same in previous commit for
clearer diff, this commit only fixes code indentation from last commit
+ minor fixes to ConsoleIO
If the server is sending invalid UUIDs, use an empty UUID instead
Improve speed and handling of %1$s tags
Fix prompt in ConsoleIO not being reset to gray
See issue #63 - Also includes minor fixes and optimizations
This bot allows users to add a bot that can detect and respond to
certain text.

The bot can be enabled/disabled via the ini file. (disabled by default)
The bot uses 2 files to let the user set what to pickup and what to
respond.
When a very long message is typed, a delay of 2 seconds is by default
used before sending parts of the long messages. The delay can be
modified or set back to 0 in configuration file, if necessary.
Move FromFile method from bots to ChatBot class
Rename file and class, removing space and underscore.
Player list updates on MC 1.8 handler did not take into account the
amount of items in the list and were only processing the first item,
including when there wasn't any item to process. Unfortunately some
weird servers were sending useless empty tab-list updates, causing a
crash. Should fix issue #78 and forum posts 1267, 1269, 1284. Thanks
dbear20, link3321, gerik43, Darkaegis, k3ldon and Ryan6578 for their bug
reports! :)
@mobdon
Copy link
Author

mobdon commented Jan 28, 2016

it come up that way when pasted it pasted it exactly like u said it does not work :/ but I know it ses me as owner thru the /tpa and it does work for /tpa thru remote

@Pokechu22
Copy link
Contributor

He probably did type it like that - it seems like markdown outside of code formatting hid it though. Hm.

@ORelio
Copy link
Member

ORelio commented Jan 28, 2016

Well this regex should work so if it don't I think I'm out of suggestions 😅
As you can see below, the regex works on the sample message you provided:

regex101-pm

And your configuration file seems OK apart from that :/

@mobdon
Copy link
Author

mobdon commented Jan 28, 2016

okay yeah that regex still doesn't respond to internal commands thru my servers msg system only responds to /tpa on my server that's how I know its still recognizing me thru remote I just wanted hangman damn ittt lol well thanks for the help

@mobdon
Copy link
Author

mobdon commented Jan 28, 2016

how would u do a public chat? and a tpa regex? seems I had to diable builtins for ur regex to work also seems the chat delay for hangman isn't enough even when its at 3 it doesn't post more that hangman version 1.0 then u never see the rest our chat delay is 2.5 so I think ur msg delay option isn't working

mobdonii pvp desteria com - minecraft console client 1_28_2016 11_49_03 am

@Pokechu22
Copy link
Contributor

Hold on, are you messaging yourself from the same account? That might cause an issue (though I'm not sure).

In any case, the default TPA regex should work without needing to change it. For normal chat, I think you would want this:

^(?:\[[^:\[\]]+\] )*([a-zA-Z0-9_]+)(?: \[[^:\[\]]+\])*: (.+)$

I can't go on the server yet but I'll try in a few hours.

@mobdon
Copy link
Author

mobdon commented Jan 29, 2016

no I have alt with close to the same name mobdon and mobdonII I have to disable the chat format built in to get commands to work but then tps don't work xD so confusing also the bot is not using the chat delay for hangman it is spaming the messages to quickly even tho delay is at 3

@mobdon
Copy link
Author

mobdon commented Jan 29, 2016

it now accepted commands but it wont accept a tpa anymore and it doesn't see my account in normal chat for hang man damn this is just peachy also the hangman needs some delay any way to change that?

@mobdon
Copy link
Author

mobdon commented Jan 29, 2016

[V] [Overlord] MOBDON [Legend]: this is how it is presented

@ORelio
Copy link
Member

ORelio commented Jan 29, 2016

Once again, the regex is working:

regex101-public

As hinted by Pokechu22 try talking from a different account set as bot owner.

@mobdon
Copy link
Author

mobdon commented Jan 29, 2016

so is the hang man isnt responding to and of the letters xD and it doesn't use the chat delay command

@ORelio
Copy link
Member

ORelio commented Jan 29, 2016

Did you start the game with /msg <botname> start?

@mobdon
Copy link
Author

mobdon commented Jan 29, 2016

yes it hits server spam when starting and it also throw me like 2 extra bot does not know command start after starting and it does not see me in main chat when I say letters

@mobdon
Copy link
Author

mobdon commented Jan 29, 2016

fixed tpa the 2 back slashes were messing it up

@ORelio
Copy link
Member

ORelio commented Jan 29, 2016

maybe an antispam plugin mutes the bot. Check for Sending '<xxxx>' lines in the bot's console.

@mobdon
Copy link
Author

mobdon commented Jan 29, 2016

no the bot say the first command then the next 2 are blocked because they are sent to faste the config delay sint working for the hangman for me alteast

@mobdon
Copy link
Author

mobdon commented Jan 29, 2016

any way to fonfigure the hangman to be slower and also the _____ is counted as spam if u could do . or , in between the underscorers that way isnt blocked mabe update hangman a bit for me? :D

@mobdon
Copy link
Author

mobdon commented Jan 29, 2016

mobdonii pvp desteria com - minecraft console client 1_29_2016 3_46_05 am
my delay is set to 3 sec and there no way its delaying that much cuz the chat spam delay is 2.5 roughly

@Pokechu22
Copy link
Contributor

How are you setting the delay? splitmessagedelay? Because that setting doesn't actually effect bots that are sending multiple messages (it effects automatic splitting of one long message) - most likely, that's what's causing the issue.

Probably, a rate-limit is necessary for bots as well.

I've got no idea why it's putting "unknown command" in private messages - that doesn't make sense.

@ORelio
Copy link
Member

ORelio commented Jan 29, 2016

Hello,

There is a conflict between Hangman and Remote Control that are both processing the command, so hangman starts the game and remote control says its an unknown command.

Hangman game definitely needs some improvements so that it gets less spam-prone, indeed.

Pokechu22 added a commit to Pokechu22/Minecraft-Console-Client that referenced this pull request Jan 30, 2016
Because bots can send several messages quickly, this adds an option to slow down the rate at which messages are produced (to avoid issues with antispam plugins).  This should help solve part of the troubles @mobdon was having in MCCTeam#105.

Right now the default time is 2 seconds per message.  However, messages are sent imediately if the bot doesn't need to delay (so if it's a bot that only outputs one or two messages, those will still happen imediately).  Also, note that it's limited per-bot right now.

I also added an optional parameter to the SendText method so that bots can avoid this behavior if they need to.  In some cases, they'll want to send multiple messages.
Pokechu22 added a commit to Pokechu22/Minecraft-Console-Client that referenced this pull request Jan 30, 2016
Because bots can send several messages quickly, this adds an option to slow down the rate at which messages are produced (to avoid issues with antispam plugins).  This should help solve part of the troubles @mobdon was having in MCCTeam#105.

Right now the default time is 2 seconds per message.  However, messages are sent imediately if the bot doesn't need to delay (so if it's a bot that only outputs one or two messages, those will still happen imediately).  Also, note that it's limited per-bot right now.

I also added an optional parameter to the SendText method so that bots can avoid this behavior if they need to.  In some cases, they'll want to send multiple messages.
@mobdon
Copy link
Author

mobdon commented Jan 30, 2016

okay thank you was just trying to clear things up thanks :D

@mobdon
Copy link
Author

mobdon commented Jan 30, 2016

also could u do a add dots or commas between the underscores that would help with spam filter :p and the possible the conflict

@ORelio
Copy link
Member

ORelio commented Jan 30, 2016

Pokechu22 added a delay between message sending, that can be configured in INI file (default: 2 seconds), so that should help. Just grab the latest dev build on AppVeyor :)

@mobdon
Copy link
Author

mobdon commented Jan 31, 2016

no there is a filter that if u have to many reocuring it shortens it like having 5 underscored in a row auto shorten to 2

@Pokechu22
Copy link
Contributor

Does separating each underscore with a space fix it? (IE, _ _ _ _ _ _ _ _ _ _)? Because I don't think replacing them with dots would fix that.

@mobdon
Copy link
Author

mobdon commented Jan 31, 2016

both will work dots commas or spaces its just to many repeating for to long it cuts down

@mobdon
Copy link
Author

mobdon commented Jan 31, 2016

also the bot is still not seeing me in chat and its still giving the cofliction from the send remote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants