Conversation
|
The approach looks like it could work. For the moment I have 2 problems that need fixing:
|
|
Well there are afaik no 32bit conda-forge packages. |
I'd be tempted to use the version on pypi then. You built the conda package, do you have an objection? |
|
There is a conda-forge issue about 32 bit. conda-forge/conda-forge.github.io#163 |
Issue #1362 : use np.intp types for indexing instead of np.int64 - According to numpy/numpy#4384 (comment), `np.intp` is the recommended dtype for indexing: "... use np.intp as dtype whenever things have to do with indexing or are logically related to indexing/array sizes. This is the natural dtype for it and it will normally also be the fastest one. - see https://docs.scipy.org/doc/numpy/user/basics.types.html - see also PR #1391 for discussion - This change should go some way towards increasing compatibility with i386/i696 (32 bit) platforms. NOTE: No dedicated testing on 32 bit yet (see WIP PR #1392 )
|
Youhou! It appears that my last tries on the matter succeeded! The tests now fails with errors that seems consistent with a 32 / 64 bits mismatch. I get errors with ENCORE in the lines of I do not get all the errors @rathann reported, though. For instance, I did not notice the ones from #1362 in the travis log. Anyway, I am going to wait for @utkbansal's #1370 to be merged before going much further here as it is going to conflict pretty much everywhere. |
Use a custom version of the ci-helper that installs 32 bits miniconda.
Conda-forge ony provides 64 bits packages, this prevent installing mmtf-python on the 32 bits build. Here I try to install it from pypi instead.
This reverts commit 8d5b3de.
Use a custom version of the ci-helper that installs 32 bits miniconda (hopefully).
See discussion in #1391
PR Checklist