Adds unwrap keyword to moment of inertia#2288
Merged
richardjgowers merged 15 commits intoMDAnalysis:developfrom Jul 9, 2019
NinadBhat:moi_unwrap
Merged
Adds unwrap keyword to moment of inertia#2288richardjgowers merged 15 commits intoMDAnalysis:developfrom NinadBhat:moi_unwrap
richardjgowers merged 15 commits intoMDAnalysis:developfrom
NinadBhat:moi_unwrap
Conversation
Merge Upstream
Updating fork
Codecov Report
@@ Coverage Diff @@
## develop #2288 +/- ##
===========================================
- Coverage 89.66% 89.66% -0.01%
===========================================
Files 172 172
Lines 21412 21421 +9
Branches 2789 2792 +3
===========================================
+ Hits 19200 19208 +8
Misses 1616 1616
- Partials 596 597 +1
Continue to review full report at Codecov.
|
richardjgowers
requested changes
Jul 8, 2019
Member
richardjgowers
left a comment
richardjgowers
left a comment
There was a problem hiding this comment.
Looking good, just remove the Flags change
| * ``True`` - Move all atoms within the primary unit cell before calculation | ||
| * ``False`` - Use coordinates as supplied | ||
|
|
||
| .. Warning:: |
Member
There was a problem hiding this comment.
We're deprecating Flags (#782), so don't add any more here
This was referenced Jul 9, 2019
Contributor
Author
|
@richardjgowers Ready to be merged |
richardjgowers
approved these changes
Jul 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2289
Changes made in this Pull Request:
PR Checklist