Add unwrap keyword to radius of gyration#2294
Closed
NinadBhat wants to merge 59 commits intoMDAnalysis:developfrom
NinadBhat:rog_unwrap
Closed
Add unwrap keyword to radius of gyration#2294NinadBhat wants to merge 59 commits intoMDAnalysis:developfrom NinadBhat:rog_unwrap
NinadBhat wants to merge 59 commits intoMDAnalysis:developfrom
NinadBhat:rog_unwrap
Conversation
Merge Upstream
Updating fork
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## develop #2294 +/- ##
==========================================
+ Coverage 89.67% 89.7% +0.03%
==========================================
Files 172 173 +1
Lines 21427 21506 +79
Branches 2794 2803 +9
==========================================
+ Hits 19214 19293 +79
Misses 1616 1616
Partials 597 597
Continue to review full report at Codecov.
|
* test_fit.py now uses proper __future__ imports, which should alleviate code style / linting issues for old style division * test_fit.py adjusted to bump coverage of fit.py to 100 %
* just minor DOC adjustments noticed in a final review
richardjgowers
requested changes
Jul 10, 2019
| atomgroup = group.atoms | ||
| pbc = kwargs.pop('pbc', flags['use_pbc']) | ||
| masses = atomgroup.masses | ||
| unwrap = kwargs.pop('unwrap', False) |
Member
There was a problem hiding this comment.
You need to update the docstring to include all keywords
Contributor
Author
|
Not sure why this PR is showing changes from #1991 even after rebase. Should I create a new PR? |
Contributor
Author
|
Copy of this PR is at #2299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1760
Changes made in this Pull Request:
PR Checklist