Remove save() methods for v1.0 - Part 1#2487
Merged
richardjgowers merged 10 commits intoMDAnalysis:developfrom Feb 7, 2020
Merged
Remove save() methods for v1.0 - Part 1#2487richardjgowers merged 10 commits intoMDAnalysis:developfrom
richardjgowers merged 10 commits intoMDAnalysis:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2487 +/- ##
========================================
Coverage 90.27% 90.27%
========================================
Files 169 169
Lines 23155 23155
Branches 3000 3000
========================================
Hits 20904 20904
Misses 1639 1639
Partials 612 612Continue to review full report at Codecov.
|
fiona-naughton
requested changes
Feb 4, 2020
Contributor
|
Looks good to me! |
richardjgowers
approved these changes
Feb 5, 2020
orbeckst
pushed a commit
that referenced
this pull request
Feb 6, 2020
This was referenced Feb 29, 2020
fiona-naughton
added
maintainability
deprecation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #1745 and #2443
Changes made in this Pull Request:
save()from contacts, diffusionmap, hole, lineardensity, and rms.filenameused bysave()methods has also been removed.So I'm doing this PR in two parts, as there's quite a few small changes and it'd probably be easier to review if I don't try to cram everything in a single PR.
PR Checklist