Skip to content

Remove deprecated hbonds.hbond_analysis#2746

Closed
RMeli wants to merge 56 commits intoMDAnalysis:developfrom
RMeli:hbonds-removal
Closed

Remove deprecated hbonds.hbond_analysis#2746
RMeli wants to merge 56 commits intoMDAnalysis:developfrom
RMeli:hbonds-removal

Conversation

@RMeli
Copy link
Copy Markdown
Member

@RMeli RMeli commented Jun 11, 2020

Related to #2739, also address #2745

Changes made in this Pull Request:

  • Removed deprecated hbonds.hbond_analysis
  • Moved hbonds.hbond_autocorrel and hbonds.wbridge_analysis to hydrogenbonds
    • Raise DeprecationWarning if hbonds is imported instead of hydrogenbonds

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

RMeli and others added 30 commits August 7, 2019 18:41
@orbeckst
Copy link
Copy Markdown
Member

orbeckst commented Feb 5, 2021

Has this been superceded by PR #2913 ?

@IAlibay
Copy link
Copy Markdown
Member

IAlibay commented Feb 5, 2021

@orbeckst yeah, I think @RMeli agreed to it in #2913 (comment). There's still hbond_autocorrel to deprecate/remove, but given how much stuff has changed, I recommend a new PR be opened for this. Feel free to re-open @RMeli if you disagree with this.

@IAlibay IAlibay closed this Feb 5, 2021
IAlibay pushed a commit that referenced this pull request Mar 13, 2021
Related to #2913, #2739 and #2746

## Work done in this PR
  - Moves hbonds.WaterBridgeAnalysis code to hydrogenbonds.WaterBridgeAnalysis
  - Add a temporary stub which links hbonds.WaterBridgeAnalysis to hydrogenbonds.WaterBridgeAnalysis
  - Some docstring changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remove-2.0 deprecated in 1.0 and to be removed in 2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants