Remove py2 things from lib#2752
Conversation
package/MDAnalysis/lib/util.py
Outdated
| # either the file isn't there or the permissions don't allow access. | ||
| if errno.errorcode[err.errno] in ['ENOENT', 'EACCES']: | ||
| six.reraise(*sys.exc_info()) | ||
| raise sys.exc_info()[0](sys.exc_info()[1]) from err |
There was a problem hiding this comment.
I'm not sure this is the right conversion here, any input would be appreciated
Codecov Report
@@ Coverage Diff @@
## develop #2752 +/- ##
===========================================
- Coverage 91.25% 91.07% -0.18%
===========================================
Files 176 177 +1
Lines 23967 23655 -312
Branches 3153 3122 -31
===========================================
- Hits 21871 21544 -327
- Misses 1470 1490 +20
+ Partials 626 621 -5
Continue to review full report at Codecov.
|
lilyminium
left a comment
lilyminium
left a comment
There was a problem hiding this comment.
LGTM, I agree that raising from None is probably the desired behaviour and that you probably don't need all the excs.
|
I didn't update CHANGELOG in #2750. I guess if we did it would go in Deprecations? |
Spoke to @richardjgowers off-github, and his take on this was that changelog changes for this won't be necessary (my bad, should have removed my question yesterday). |
richardjgowers
left a comment
richardjgowers
left a comment
There was a problem hiding this comment.
Yeah the thinking is Changelog is a user tool to understand how the package has changed. These changes don’t change anything for the user
lilyminium
left a comment
lilyminium
left a comment
There was a problem hiding this comment.
Looks good, just a stray six in there. Thank you @IAlibay!
Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
- remove six and __future__ imports
5 participants
Towards #2541
Changes made in this Pull Request:
Question:
Do we want changelog entries for these things?PR Checklist