Skip to content

Remove py2 things from analysis#2753

Merged
richardjgowers merged 8 commits intoMDAnalysis:developfrom
IAlibay:rm-py2-analysis
Jun 15, 2020
Merged

Remove py2 things from analysis#2753
richardjgowers merged 8 commits intoMDAnalysis:developfrom
IAlibay:rm-py2-analysis

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Jun 13, 2020

Fixes #2541

Changes made in this Pull Request:

  • Removes six & future imports from analysis

Note:

  • Omitted hbond_analysis & hole as set for removal

Question:

  • test_wbridge doesn't have any of the file header blurb, do we want it add it in?

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #2753 into develop will decrease coverage by 0.01%.
The diff coverage is 73.80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2753      +/-   ##
===========================================
- Coverage    91.17%   91.16%   -0.02%     
===========================================
  Files          176      176              
  Lines        23798    23734      -64     
  Branches      3134     3135       +1     
===========================================
- Hits         21699    21636      -63     
+ Misses        1476     1475       -1     
  Partials       623      623              
Impacted Files Coverage Δ
package/MDAnalysis/analysis/contacts.py 100.00% <ø> (ø)
package/MDAnalysis/analysis/data/filenames.py 100.00% <ø> (ø)
package/MDAnalysis/analysis/diffusionmap.py 93.10% <ø> (-0.23%) ⬇️
package/MDAnalysis/analysis/dihedrals.py 96.66% <ø> (-0.06%) ⬇️
package/MDAnalysis/analysis/distances.py 97.50% <ø> (-0.07%) ⬇️
package/MDAnalysis/analysis/encore/__init__.py 100.00% <ø> (ø)
package/MDAnalysis/analysis/encore/bootstrap.py 100.00% <ø> (ø)
...sis/analysis/encore/clustering/ClusteringMethod.py 96.87% <ø> (-0.05%) ⬇️
.../MDAnalysis/analysis/encore/clustering/__init__.py 100.00% <ø> (ø)
...e/MDAnalysis/analysis/encore/clustering/cluster.py 96.15% <ø> (-0.08%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085ac0f...e3d5a7b. Read the comment docs.

@IAlibay
Copy link
Member Author

IAlibay commented Jun 13, 2020

As per #2752 (comment), I've reverted to raising from None.

@IAlibay IAlibay mentioned this pull request Jun 13, 2020
4 tasks
@IAlibay IAlibay changed the title Rm py2 analysis Remove py2 things from analysis Jun 14, 2020
@orbeckst orbeckst added the remove-2.0 deprecated in 1.0 and to be removed in 2.0 label Jun 15, 2020
@richardjgowers richardjgowers merged commit da72d55 into MDAnalysis:develop Jun 15, 2020
@IAlibay IAlibay deleted the rm-py2-analysis branch June 15, 2020 10:37
PicoCentauri pushed a commit to PicoCentauri/mdanalysis that referenced this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainability remove-2.0 deprecated in 1.0 and to be removed in 2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Python 2 constructs

4 participants