Skip to content

Use unittest.mock instead of mock#2779

Merged
richardjgowers merged 5 commits intoMDAnalysis:developfrom
IAlibay:unit-mock
Jun 21, 2020
Merged

Use unittest.mock instead of mock#2779
richardjgowers merged 5 commits intoMDAnalysis:developfrom
IAlibay:unit-mock

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Jun 20, 2020

Fixes #2777

Changes made in this Pull Request:

  • Removes dependency on mock and uses unittest.mock instead.

PR Checklist

  • Tests?
  • Docs? N/A
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #2779 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2779   +/-   ##
========================================
  Coverage    91.12%   91.12%           
========================================
  Files          179      179           
  Lines        23844    23844           
  Branches      3144     3144           
========================================
  Hits         21727    21727           
  Misses        1496     1496           
  Partials       621      621           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016f2c6...f910424. Read the comment docs.

"pytest": [],
"nose": [],
"psutil": [],
"mock": [],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to revert this change based on @orbeckst's comment: #2778 (comment)

@richardjgowers richardjgowers merged commit 2fb1ade into MDAnalysis:develop Jun 21, 2020
PicoCentauri pushed a commit to PicoCentauri/mdanalysis that referenced this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace mock with unittest.mock

3 participants