add analytics and privacy policy

[orbeckst]

Fixes #2813

Changes made in this Pull Request:

• add GoatCounter for basic analytics
• add link to our Privacy Policy

PR Checklist

• Tests?
• Docs?
• CHANGELOG updated?
• Issue raised/referenced?

[pep8speaks]

Hello @orbeckst! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file package/MDAnalysis/core/_get_readers.py:

Line 254:80: E501 line too long (101 > 79 characters)

• In the file package/MDAnalysis/core/universe.py:

Line 835:80: E501 line too long (94 > 79 characters)

[orbeckst]

This is what the rendered footer looks like:

[lilyminium]

Thank you @orbeckst for adding this! LGTM, just the thought below.

[jbarnoud]

What is the CSS file that gets deleted?

[lilyminium]

I think it was custom CSS for the alabaster theme. I switched our docs to the RTD theme and used CSS from custom.css (https://github.com/MDAnalysis/mdanalysis/pull/2399/files#diff-806739c80780d4a61187355682fd6640L9) but never deleted the other file in #2399.

[orbeckst]

What is the CSS file that gets deleted?

readable.css was used previously and imported in custom.css. We are not using readable.css anymore (it should have been deleted when we switched over to the MDA-RDT User Guide theme).

EDIT: sorry for the noise – somehow I didn't have @lilyminium 's reply on my page when I saw the question (stale page in browser...)

[orbeckst]

See also PR MDAnalysis/pmda#129 for such a removal.

[codecov]

Codecov Report

Merging #2828 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2828   +/-   ##
========================================
  Coverage    92.22%   92.22%           
========================================
  Files          184      184           
  Lines        24141    24141           
  Branches      3123     3123           
========================================
  Hits         22263    22263           
  Misses        1813     1813           
  Partials        65       65           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8abbee...fd3cbf5. Read the comment docs.

[orbeckst]

@lilyminium where do the development docs live at the moment? The usual https://www.mdanalysis.org/mdanalysis redirects to the https://docs.mdanalysis.org/1.0.0/ docs and the 1.0.0 docs do not have a version selector. I’d like to see if the privacy footer properly displays.

I’ll still have to backport to 1.0.x #2798 but I assume we’ll have to push these docs manually?

[lilyminium]

https://docs.mdanalysis.org/dev <https://docs.mdanalysis.org/dev> redirects to 2.0.0-dev. I think 1.0.0 doesn’t have a version because I built those manually to resolve an issue where they were redirecting to the user guide. Backporting the Travis changes + maintainer script to 1.0.0 and 1.0.x will make those docs automatically :-)

…

On 9 Jul 2020, at 4:45 pm, Oliver Beckstein ***@***.***> wrote: @lilyminium <https://github.com/lilyminium> where do the development docs live at the moment? The usual https://www.mdanalysis.org/mdanalysis <https://www.mdanalysis.org/mdanalysis> redirects to the https://docs.mdanalysis.org/1.0.0/ <https://docs.mdanalysis.org/1.0.0/> docs and the 1.0.0 docs do not have a version selector. I’d like to see if the privacy footer properly displays. I’ll still have to backport to 1.0.x #2798 <#2798> but I assume we’ll have to push these docs manually? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2828 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHNMOXKDHUHJGERYINQVBZDR2VRSPANCNFSM4OT7ADDA>.