Skip to content

Remove helanal#2929

Merged
IAlibay merged 4 commits intoMDAnalysis:developfrom
lilyminium:helano
Sep 23, 2020
Merged

Remove helanal#2929
IAlibay merged 4 commits intoMDAnalysis:developfrom
lilyminium:helano

Conversation

@lilyminium
Copy link
Member

@lilyminium lilyminium commented Sep 2, 2020

Fixes #

Changes made in this Pull Request:

  • remove old helanal module

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@lilyminium lilyminium added this to the 2.0 milestone Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.05%. Comparing base (2c5e385) to head (8ac7d01).
⚠️ Report is 1454 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2929      +/-   ##
===========================================
+ Coverage    93.02%   93.05%   +0.03%     
===========================================
  Files          187      186       -1     
  Lines        24962    24613     -349     
  Branches      3261     3187      -74     
===========================================
- Hits         23220    22904     -316     
+ Misses        1694     1661      -33     
  Partials        48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this :)

Can you also add a change under the changelog's changes?

@IAlibay
Copy link
Member

IAlibay commented Sep 4, 2020

@lilyminium

/home/travis/build/MDAnalysis/mdanalysis/package/MDAnalysis/analysis/helix_analysis.py:docstring of MDAnalysis.analysis.helix_analysis:10:citation not found: Bansal2000

I guess the citation needs to be ported over.

There's also some flaky lib_dcd failure on azure, it's not the first time I've seen it, not sure what's going on there.

@lilyminium
Copy link
Member Author

Thanks for looking at this @IAlibay!

@lilyminium lilyminium requested a review from IAlibay September 23, 2020 04:50
@IAlibay IAlibay merged commit 3df4581 into MDAnalysis:develop Sep 23, 2020
PicoCentauri added a commit to PicoCentauri/mdanalysis that referenced this pull request Mar 30, 2021
Towards MDAnalysis#2739

Removes the old helanal code in favour of helix_analysis
@fiona-naughton fiona-naughton added maintainability deprecation Deprecated functionality to give advance warning for API changes. labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecated functionality to give advance warning for API changes. maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants