ensure that unistd.h is included on recent clang#2949
Merged
Conversation
- fix #2934 - use unistd.h in ENCORE's spe.c when not WIN32 (e.g. __unix__ or __APPLE__ but to be consistent with other uses in the code base we do not specifically test for __unix__ || __APPLE__) - update CHANGELOG
orbeckst
force-pushed
the
issue-2934-unistd-apple
branch
from
a1a7c9e to
56c5ea9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2949 +/- ##
========================================
Coverage 93.02% 93.02%
========================================
Files 187 187
Lines 24962 24962
Branches 3261 3261
========================================
Hits 23220 23220
Misses 1694 1694
Partials 48 48 Continue to review full report at Codecov.
|
11 tasks
lilyminium
approved these changes
Sep 22, 2020
Member
lilyminium
left a comment
lilyminium
left a comment
There was a problem hiding this comment.
Compiles for me, thanks @orbeckst!
Just because I looked it up to check that _WIN32 is defined on 64-bit:
_WIN32 Defined as 1 when the compilation target is 32-bit ARM, 64-bit ARM, x86, or x64. Otherwise, undefined.
Member
Author
|
Added to master (1.0.x) in ecbbc4e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2934
Changes made in this Pull Request:
PR Checklist